Use as rather than map and discard #3708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3708 +/- ##
=======================================
Coverage 90.24% 90.24%
=======================================
Files 391 391
Lines 8863 8863
Branches 270 227 -43
=======================================
Hits 7998 7998
Misses 865 865 |
rossabaker
approved these changes
Dec 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a few places where we do
map(f)(_ => a). This is the same as Functor.as, but it hides it from the typeclass implementation. Some types can optimize as by discarding any trailing map operators from their internal AST (such as parsers or other compute types that are not evaluated until later). By not calling typeclass methods we potentially slow those implementations down.